fix(selectivity): dont rely on file stat's atime when clearing dumps#1223
Merged
KuznetsovRoman merged 3 commits intomasterfrom Mar 19, 2026
Merged
fix(selectivity): dont rely on file stat's atime when clearing dumps#1223KuznetsovRoman merged 3 commits intomasterfrom
KuznetsovRoman merged 3 commits intomasterfrom
Conversation
commit: |
KuznetsovRoman
commented
Mar 19, 2026
| const { enabled, testDependenciesPath } = browserConfig.selectivity; | ||
|
|
||
| if (enabled && !selectivityRoots.includes(testDependenciesPath)) { | ||
| if (selectivityShouldWrite(enabled) && !selectivityRoots.includes(testDependenciesPath)) { |
Member
Author
There was a problem hiding this comment.
Merge changes from branch with selectivity-modes
on "readonly" mode, no dumps should be touched
| export const getSelectivityTestsPath = (testDependenciesPath: string): string => | ||
| path.join(testDependenciesPath, "tests"); | ||
|
|
||
| export const getTestSelectivityDumpId = (test: Test): string => test.id; |
Member
Author
There was a problem hiding this comment.
Just to not rely on assertion "dump id is test.id" in many places
| assert.notCalled(fsStub.readdir); | ||
| }); | ||
|
|
||
| it("should skip browsers with selectivity in read-only mode", async () => { |
Member
Author
There was a problem hiding this comment.
Those are "clearUnusedSelectivityDumps" tests
shadowusr
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.