fix(selectivity): ensure selectivity dump has no stale data by KuznetsovRoman · Pull Request #1214 · gemini-testing/testplane

KuznetsovRoman · 2026-02-27T00:48:26Z

No description provided.

pkg-pr-new · 2026-02-27T00:50:20Z

npm i https://pkg.pr.new/gemini-testing/testplane@1214

commit: af5b616

KuznetsovRoman · 2026-02-27T00:49:29Z

src/browser/cdp/selectivity/hash-writer.ts

        dependencies.modules.forEach(dependency => this._addModuleDependency(dependency));
    }

-    async commit(): Promise<void> {


Removing logic to "not remove anything extra"
It was useful when hash writes were concurrent

KuznetsovRoman · 2026-02-27T00:51:12Z

src/browser/cdp/selectivity/index.ts

+                }
+
+                // File was not used in this run
+                if (fileStat.atimeMs < performance.timeOrigin && fileStat.isFile()) {


"atime" - time file was accessed
"clearUnusedSelectivityDumps" is called after successful run
If file was not accessed in successful run, we can safely delete it

KuznetsovRoman · 2026-02-27T15:18:28Z

src/browser/cdp/selectivity/fs-cache.ts

    try {
        const stats = await libUVLimited(() => fs.stat(flagFilePath));
-        return stats.mtimeMs >= processStartTime;
+        return stats.mtimeMs >= performance.timeOrigin;


Turns out, there is special value for that, so we dont need "new Date()" hacks

KuznetsovRoman · 2026-03-13T09:36:47Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19810a9bc8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-13T09:43:24Z

src/browser/cdp/selectivity/hash-writer.ts

+        await writeTo(this._stagedFileHashes, fileContents.files);
+        await writeTo(this._stagedModuleHashes, fileContents.modules);
+        await writeTo(this._stagedPatternHashes, fileContents.patterns);

-        markAsCommited(updatedModules, this._stagedModuleHashes);
-        markAsCommited(updatedFiles, this._stagedFileHashes);
+        await writeJsonWithCompression(this._selectivityHashesPath, fileContents, this._compresion);


Merge existing hashes before overwriting hashes.json

HashWriter.save now writes a brand-new hash object populated only from currently staged entries, but staging is filled only from executed tests (onTestDependencies) and changed disable patterns (updateSelectivityHashes). This drops hashes for skipped tests and unchanged patterns, so on the next process run HashReader.getTestChangedDeps/patternHasChanged read undefined and treat those dependencies as changed, causing selectivity to rerun tests (or whole browsers) even when source files are unchanged.

Useful? React with 👍 / 👎.

now writes a brand-new hash object populated only from currently staged entries

Yes.

but staging is filled only from executed tests

No. It is also filled in master thread while calculating current file hashes.

and changed disable patterns

Unchanged too. For same reasons.

chatgpt-codex-connector · 2026-03-13T09:43:24Z

src/browser/cdp/selectivity/index.ts

+                }
+
+                // File was not used in this run
+                if (fileStat.atimeMs < performance.timeOrigin && fileStat.isFile()) {


Stop using atime as a per-run usage marker

The stale-file check deletes dumps based on fileStat.atimeMs < performance.timeOrigin, but on filesystems mounted with relatime/noatime a read during this run may not update atime, so actively used dependency dumps can still look stale and get removed. In those environments, the cleanup step can delete valid selectivity dumps and force unnecessary full reruns on the next execution.

Useful? React with 👍 / 👎.

sipayRT · 2026-03-17T15:48:31Z

src/browser/cdp/selectivity/index.ts

+
+            if (accessError) {
+                if (!("code" in accessError && accessError.code === "ENOENT")) {
+                    debugSelectivity(`Couldn't access "${testsPath}" to clear stale files: %O`, accessError);


not actionable

Those are debug logs, are they supposed to be actionable to user?
I thought, they need to be clear to us

sipayRT · 2026-03-17T15:51:10Z

src/browser/cdp/selectivity/index.ts

+
+    for (const browserId of browserIds) {
+        const browserConfig = config.forBrowser(browserId);
+        const { enabled, testDependenciesPath } = browserConfig.selectivity;


but if I use grep option, selectivity will be disabled, right?

"clearUnusedSelectivityDumps" is called in "testplane.ts" inside:

if (!shouldDisableSelectivity && !this.isFailed())

branch, with "updateSelectivityHashes" function call.
Both will not be called because "shouldDisableSelectivity" will be "true" in this case (because of "grep")

sipayRT · 2026-03-17T15:52:08Z

src/browser/cdp/selectivity/index.ts

+                            filesDeleted++;
+                        })
+                        .catch(err => {
+                            debugSelectivity(`Couldn't remove stale file "${filePath}": %O`, err);


not actionable

Since there are plenty of code like this, i will address the issue "actionable fs-errors" in the following pr to avoid code duplication + merge issues

test/src/browser/cdp/selectivity/index.ts

sipayRT · 2026-03-17T15:55:57Z

test/src/browser/cdp/selectivity/index.ts

+            assert.calledOnce(getSelectivityTestsPathStub);
+            assert.calledWith(getSelectivityTestsPathStub, "/test/deps");
+            assert.calledOnce(fsStub.access);
+            assert.calledWith(fsStub.access, "/test/deps/tests", 6); // R_OK | W_OK = 4 | 2 = 6


R_OK + W_OK = 4 + 2 = 6?

Not quite.
0b00000100
0b00000010
0b00000110
Its bitwise "or", not "sum"

test/src/browser/cdp/selectivity/index.ts

KuznetsovRoman force-pushed the TESTPLANE-921.clear_dump_unused branch 2 times, most recently from 2527862 to 19810a9 Compare February 27, 2026 00:56

KuznetsovRoman commented Feb 27, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

sipayRT approved these changes Mar 17, 2026

View reviewed changes

fix(selectivity): dont save unused hashes to selectivity hash map

6550d06

KuznetsovRoman force-pushed the TESTPLANE-921.clear_dump_unused branch from 19810a9 to 93c7d77 Compare March 18, 2026 14:41

fix(selectivity): remove stale test file hashes

af5b616

KuznetsovRoman force-pushed the TESTPLANE-921.clear_dump_unused branch from 93c7d77 to af5b616 Compare March 18, 2026 14:46

KuznetsovRoman merged commit 0bc46f6 into master Mar 18, 2026
5 of 7 checks passed

KuznetsovRoman deleted the TESTPLANE-921.clear_dump_unused branch March 18, 2026 14:58

Conversation

KuznetsovRoman commented Feb 27, 2026

Uh oh!

pkg-pr-new bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KuznetsovRoman commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KuznetsovRoman Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pkg-pr-new bot commented Feb 27, 2026 •

edited

Loading

KuznetsovRoman Mar 18, 2026 •

edited

Loading