feat: remove slides.find and sheets.find in favor of drive.search#271
feat: remove slides.find and sheets.find in favor of drive.search#271allenhutchison wants to merge 3 commits intomainfrom
Conversation
Closes #268 Remove the redundant find methods from SlidesService and SheetsService, consolidating all file-finding through drive.search. This also drops the Drive API dependency (drive_v3, getDriveClient, buildDriveSearchQuery, MIME_TYPES) from both services entirely. Changes: - Remove slides.find and sheets.find tool registrations from index.ts - Remove find methods and Drive API deps from SlidesService and SheetsService - Remove associated tests and Drive API mocks - Update WORKSPACE-Context.md with MIME type filter examples for all types - Fix stale docs.find/docs.move references in Docs skill - Create new Sheets and Slides skills with drive.search guidance
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the file-finding capabilities across Google Workspace services by deprecating redundant Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively refactors the file search functionality by removing the specific slides.find and sheets.find methods in favor of the more generic drive.search. The changes are well-executed, including updates to tests and extensive documentation improvements with new skill files for Sheets and Slides. My review includes a couple of suggestions to further improve consistency and code cleanliness.
Remove the Docs/Sheets/Slides section (format selection, content handling) since these are now covered by individual skills. Replace inline Sheets nuances with a skill cross-reference, add Slides cross-reference.
| ### Finding Documents | ||
|
|
||
| Use `docs.find` to search by title. Supports pagination with `pageToken`. | ||
| Use `drive.search` with a document MIME type filter to find Google Docs: |
There was a problem hiding this comment.
ah didn't realize there are specific skills that need to be updated with #256. Thanks!
Address PR review feedback: - Remove buildDriveSearchQuery and MIME_TYPES from DriveQueryBuilder.ts (no longer used after removing slides.find and sheets.find) - Keep only escapeQueryString (still used by DriveService) - Rewrite DriveQueryBuilder tests to cover escapeQueryString only - Add fullText contains note to Docs skill for consistency
2 participants
Closes #268
Summary
Remove the redundant
findmethods fromSlidesServiceandSheetsService, consolidating all file-finding throughdrive.search. This also drops the Drive API dependency (drive_v3,getDriveClient,buildDriveSearchQuery,MIME_TYPES) from both services entirely.Changes
Service cleanup
slides.findandsheets.findtool registrations fromindex.tsfindmethods and Drive API dependencies fromSlidesServiceandSheetsServiceDocumentation
WORKSPACE-Context.mdwith MIME type filter examples for Docs, Sheets, and Slidesdocs.find/docs.movereferences in Docs skill → now referencesdrive.search/drive.moveFileskills/sheets/SKILL.md) withdrive.searchguidanceskills/slides/SKILL.md) withdrive.searchguidanceMigration
Users should use
drive.searchwith MIME type filters instead:mimeType='application/vnd.google-apps.spreadsheet' and name contains 'query'mimeType='application/vnd.google-apps.presentation' and name contains 'query'Verification