Skip to content

Comments

Improve detection of s3fs and skip tests requiring it#548

Merged
ap-- merged 1 commit intofsspec:mainfrom
avalentino:bugfix/s3fs-detection
Feb 22, 2026
Merged

Improve detection of s3fs and skip tests requiring it#548
ap-- merged 1 commit intofsspec:mainfrom
avalentino:bugfix/s3fs-detection

Conversation

@avalentino
Copy link
Contributor

No description provided.

@ap--
Copy link
Collaborator

ap-- commented Feb 22, 2026

Hello @avalentino

could you clarify under what circumstances this is important?
Running the test suite via nox -s tests pulls in s3fs

@avalentino
Copy link
Contributor Author

avalentino commented Feb 22, 2026

Hello @avalentino

could you clarify under what circumstances this is important? Running the test suite via nox -s tests pulls in s3fs

I maintain the Debian package for universal_pathlib.
The build process is done in isolation (no access to the internet) and the test suite is run regularly at each update of the package.
Without a pytest mark we would have test errors or would be forced to exclude tests one by one.

When the patch was submitted s3fs was not available in Debian.
Many of the test using it are already automatically skipped if s3fs is missing.
There are few ones for which this does not happen and those are addressed by this PR.

@ap-- ap-- merged commit 3093b23 into fsspec:main Feb 22, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants