Fix positioning bug when creating new nodes#288
Open
chillbram wants to merge 1 commit intofranzose:masterfrom
Open
Fix positioning bug when creating new nodes#288chillbram wants to merge 1 commit intofranzose:masterfrom
chillbram wants to merge 1 commit intofranzose:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a new node with both a
parent_idandpositionspecified, the positioning is set incorrectly. The$latest--subtraction, which ensures that the position value does not balloon should not run when creating a new node as now you do want to allow the position number to increase.Example:
I'm creating N3 with the
parent_idof N1 and apositionof1. The figure below is how it should turn out. In the saving step,Entity::getLatestPosition()correctly returns 1 (as the position of N2 is 0). However this is subtracted to 0 as the position column is "dirty" and we're "reparenting".