Merged
Conversation
stijnpotters1
requested review from
philipsens
and removed request for
MatthijsSmets
philipsens
requested review from
Copilot
and removed request for
philipsens
There was a problem hiding this comment.
Pull Request Overview
This PR updates the FrontendForwardController to use a more specific HTTP method mapping by replacing @RequestMapping with @GetMapping. This change restricts the endpoint to only handle GET requests instead of accepting all HTTP methods.
- Replaced
@RequestMappingwith@GetMappingfor the forward method - Updated imports to reflect the annotation change
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+4
to
+10
| import org.springframework.web.bind.annotation.GetMapping; | ||
| import org.springframework.web.bind.annotation.PathVariable; | ||
| import org.springframework.web.bind.annotation.RequestMapping; | ||
|
|
||
| @Controller | ||
| public class FrontendForwardController { | ||
|
|
||
| @RequestMapping(value = "/{path:[^\\.]*}") | ||
| @GetMapping(value = "/{path:[^\\.]*}") |
There was a problem hiding this comment.
Changing from @RequestMapping to @GetMapping creates a breaking change for clients that may be using other HTTP methods (POST, PUT, DELETE) to access this endpoint. Consider if this restriction is intentional, as frontend routing typically needs to handle various HTTP methods for SPA navigation.
philipsens
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.