Skip to content

apps: Add logic to optionally build things in subdirectories#406

Merged
doanac merged 1 commit intofoundriesio:masterfrom
doanac:build-subdirs
Mar 5, 2026
Merged

apps: Add logic to optionally build things in subdirectories#406
doanac merged 1 commit intofoundriesio:masterfrom
doanac:build-subdirs

Conversation

@doanac
Copy link
Member

@doanac doanac commented Mar 4, 2026

When users want to use something like submodules, they'll wind up with repository structure looking like:

repo:
submodule-foo/
ui/Dockerfile
docker-compose.yml

This change will allow us to build a container named "submodule-foo-ui"

When users want to use something like submodules, they'll wind up with
repository structure looking like:

 repo:
    submodule-foo/
                  ui/Dockerfile
		  docker-compose.yml

This change will allow us to build a container named "submodule-foo-ui"

Signed-off-by: Andy Doan <andy@foundries.io>
Copy link
Contributor

@mike-sul mike-sul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-sul
Copy link
Contributor

mike-sul commented Mar 5, 2026

Just another option/idea to implement this feature: introduce an additional file at containers.git level that contains a list of additional directories to build an image for:

CTR_IMAGE_DIRS = "<path> [; <path>]..."

It doesn't require from the git repo included as submodule to be aware about been used by FF.

@doanac doanac merged commit 8ddbcd1 into foundriesio:master Mar 5, 2026
2 checks passed
@doanac doanac deleted the build-subdirs branch March 5, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants