Skip to content

STCLI-279 remove configuration warnings for '--federate' flag#394

Open
JohnC-80 wants to merge 1 commit intomainfrom
STCLI-279
Open

STCLI-279 remove configuration warnings for '--federate' flag#394
JohnC-80 wants to merge 1 commit intomainfrom
STCLI-279

Conversation

@JohnC-80
Copy link
Copy Markdown
Contributor

@JohnC-80 JohnC-80 commented Mar 4, 2026

This PR removes the warnings about building/serving without a config file if the --federate command is used, where configs are optional.

It also adds some more context-specific messaging about where the command is executed - in the ui-module or host app space.

@JohnC-80 JohnC-80 requested a review from a team as a code owner March 4, 2026 17:34
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 4, 2026

Jest Unit Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit dc41de9. ± Comparison against base commit b138c47.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 4, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

zburke
zburke previously approved these changes Mar 5, 2026
@zburke zburke self-requested a review March 12, 2026 21:29
@zburke zburke dismissed their stale review March 13, 2026 03:17

With further testing, I realzied stripes-webpack no longer starts the local registry service when stripes-cli is called like build --federate instead of build path/to/stripes.config.js --federate.

@JohnC-80
Copy link
Copy Markdown
Contributor Author

JohnC-80 commented Mar 24, 2026

@zburke - we don't automatically start the local registry server with build - we never have The POC may have done this - but is it really necessary? The intent with build is to take the output and push it somewhere else, not to develop locally. If starting the registry server is something desired with build, it will need a separate option. serve on the other hand, will start the registry, as it's meant for local development.

@zburke
Copy link
Copy Markdown
Member

zburke commented Mar 26, 2026

Whoops, typo: you're right that we don't (and shouldn't) start the local registry on build. The problem is that I don't see the registry starting when serving a platform like ```
yarn stripes serve --federate

The local registry only starts for me when I pass in a config file like

yarn stripes serve ./stripes.config.js.local --federate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants