You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With further testing, I realzied stripes-webpack no longer starts the local registry service when stripes-cli is called like build --federate instead of build path/to/stripes.config.js --federate.
@zburke - we don't automatically start the local registry server with build - we never have The POC may have done this - but is it really necessary? The intent with build is to take the output and push it somewhere else, not to develop locally. If starting the registry server is something desired with build, it will need a separate option. serve on the other hand, will start the registry, as it's meant for local development.
Whoops, typo: you're right that we don't (and shouldn't) start the local registry on build. The problem is that I don't see the registry starting when serving a platform like ```
yarn stripes serve --federate
The local registry only starts for me when I pass in a config file like
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the warnings about building/serving without a config file if the
--federatecommand is used, where configs are optional.It also adds some more context-specific messaging about where the command is executed - in the ui-module or host app space.