MD post check param loosen MDs immutable check#1439
Merged
adamdickmeiss merged 4 commits intomasterfrom Mar 27, 2026
Merged
Conversation
ArgonV
requested changes
Mar 26, 2026
There was a problem hiding this comment.
A small, sane change. I think module developers would approve. Should the README.md and other docs also be updated @adamdickmeiss ?
MikeTaylor
reviewed
Mar 26, 2026
Contributor
MikeTaylor
left a comment
MikeTaylor
left a comment
There was a problem hiding this comment.
The purpose of this to allow an MD to be posted with different permissions from the previous version, right? That's properly useful and and I welcome it.
I agree with @ArgonV that a line in the README, or at least in the Guide, would be helpful.
julianladisch
requested changes
Mar 26, 2026
Contributor
julianladisch
left a comment
julianladisch
left a comment
There was a problem hiding this comment.
Please update the javadoc of the check parameter:
Please update the API documentation of the check parameter:
|
adamdickmeiss
deleted the
post-mds-check-parameter-also-loosen-immutability
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally Module Descriptors are immutable. The
checkparameter (default true) ensures thatthe MD has all its interfaces known at POST. The check=false disables that check. This PR also disables
the immutability check, when check=false.
This is mostly a convenience for developers; not to be used in production.