Skip to content

Comments

fix: adjust current page param after add new sponsor to summit#803

Open
tomrndom wants to merge 1 commit intomasterfrom
fix/sponsor-list-save-last-page
Open

fix: adjust current page param after add new sponsor to summit#803
tomrndom wants to merge 1 commit intomasterfrom
fix/sponsor-list-save-last-page

Conversation

@tomrndom
Copy link

@tomrndom tomrndom commented Feb 23, 2026

ref: https://app.clickup.com/t/86b8m54t7

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • Bug Fixes
    • Fixed sponsor list pagination to return to the first page after creating a new sponsor, providing consistent and predictable navigation behavior when managing sponsors.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom requested a review from smarcet February 23, 2026 22:11
@coderabbitai
Copy link

coderabbitai bot commented Feb 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e6557b6 and 89a6e5f.

📒 Files selected for processing (1)
  • src/pages/sponsors/sponsor-list-page.js

📝 Walkthrough

Walkthrough

Removed the lastPage prop from SponsorListPage's destructured props. Updated post-sponsor-creation refresh logic to reload sponsors from DEFAULT_CURRENT_PAGE instead of lastPage, resetting pagination to a default first page while preserving perPage, order, and orderDir settings.

Changes

Cohort / File(s) Summary
Post-creation refresh logic
src/pages/sponsors/sponsor-list-page.js
Removed lastPage prop from component interface and updated sponsor refresh to use DEFAULT_CURRENT_PAGE instead of the previous page reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • smarcet

Poem

🐰 Hopping through sponsor pages with glee,
Removed lastPage, now we default to three!
First page awaits with a fresh new view,
DEFAULT_CURRENT_PAGE—the right way to brew! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adjusting the current page parameter after adding a new sponsor, which aligns with the code change that resets to DEFAULT_CURRENT_PAGE.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/sponsor-list-save-last-page

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant