Conversation
pyop2/compilation.py
Outdated
| _cflags = ("-fPIC", "-Wall", "-std=gnu11") | ||
| _cxxflags = ("-fPIC", "-Wall") | ||
| _ldflags = ("-shared",) | ||
| _ldflags = ("-shared", "-lgsl", "-lgslcblas") |
There was a problem hiding this comment.
@connorjward what does -shared mean? This is obviously not the correct way to add libraries, please correct me.
There was a problem hiding this comment.
I think -shared means to make an .so instead of a .a file.
Regardless I think you maybe want to add this here: https://github.com/firedrakeproject/firedrake/blob/main/pyop2/global_kernel.py#L399. It might be nice to make this optional though since I don't know if we can be confident that all platforms will have this library available. However doing that would involve passing information from TSFC to PyOP2 which might be a little involved.
pyop2/compilation.py
Outdated
| _cflags = ("-fPIC", "-Wall", "-std=gnu11") | ||
| _cxxflags = ("-fPIC", "-Wall") | ||
| _ldflags = ("-shared",) | ||
| _ldflags = ("-shared", "-lgsl", "-lgslcblas") |
There was a problem hiding this comment.
I think -shared means to make an .so instead of a .a file.
Regardless I think you maybe want to add this here: https://github.com/firedrakeproject/firedrake/blob/main/pyop2/global_kernel.py#L399. It might be nice to make this optional though since I don't know if we can be confident that all platforms will have this library available. However doing that would involve passing information from TSFC to PyOP2 which might be a little involved.
pbrubeck
force-pushed
the
pbrubeck/hypergeometric
branch
from
360f315 to
d69227a
Compare
|
|
||
| expressions = [((1/3, 1/2, 1), Constant(0.9999) * x), | ||
| ((1/2, 1/2, 1), Constant(0.9999) * sqrt(x**2+y**2)), | ||
| ((-1/2, 1/2, 1), Constant(0.4999) * sqrt(x*x + y*y))] |
There was a problem hiding this comment.
This case is giving a different result for arguments >= 0.5 when compared to scipy
2 participants
Description
Enables codegen for
ufl.hyp2f1Depends on inducer/loopy#986 FEniCS/ufl#468