Netgen: curved meshes from Mesh constructor and refine_marked_elements#4930
Open
Netgen: curved meshes from Mesh constructor and refine_marked_elements#4930
Conversation
connorjward
requested changes
Feb 27, 2026
Contributor
connorjward
left a comment
There was a problem hiding this comment.
This is a way better way to build these meshes. Could you amend our demos?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously we had 2 methods to construct a curved Mesh out of a netgen mesh:
curve_field(degree)to produce new coordinates, then you could create a firedrake Mesh out of the curve field. The final Firedrake Mesh will not know that it comes from a netgen mesh, and therefore cannot be adaptively refined.This PR enables the more intuitive approach (while not removing the other two)
Also propagates the mesh order in
refine_marked_elements.