Skip to content

feat: add famedly control module in docker image#239

Merged
jason-famedly merged 3 commits intomasterfrom
tt/famedly-control-docker
Mar 11, 2026
Merged

feat: add famedly control module in docker image#239
jason-famedly merged 3 commits intomasterfrom
tt/famedly-control-docker

Conversation

@FrenchGithubUser
Copy link
Member

@FrenchGithubUser FrenchGithubUser commented Feb 26, 2026

SYN-9

edit by jason: Added in the same testing as is done for the invite-checker and the token authenticator. Also added in building for the TIM 1.1 image to maintain consistency

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.14%. Comparing base (ba6100f) to head (e09b1a5).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   80.14%   80.14%   -0.01%     
==========================================
  Files         501      501              
  Lines       71375    71375              
  Branches    10732    10732              
==========================================
- Hits        57202    57201       -1     
- Misses      10919    10920       +1     
  Partials     3254     3254              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6100f...e09b1a5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the famedly-control-synapse module to the Famedly Synapse Docker image build by introducing a new versioned build argument and extending the mod-pack build matrix used by CI.

Changes:

  • Add FCS_VERSION build arg and install famedly-control-synapse in docker/Dockerfile-famedly.
  • Introduce mod020 including fcs-version and switch the currently-built mod pack list to mod017 + mod020.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
docker/Dockerfile-famedly Adds a new build arg and pip-install of famedly-control-synapse.
.ci/scripts/calculate_builds.py Adds mod020 with fcs-version and updates which mod packs are built.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@FrenchGithubUser FrenchGithubUser force-pushed the tt/famedly-control-docker branch from e1df2c7 to 72d3120 Compare March 5, 2026 13:23
@jason-famedly jason-famedly force-pushed the tt/famedly-control-docker branch from d66cc78 to d59202f Compare March 11, 2026 12:37
@jason-famedly jason-famedly marked this pull request as ready for review March 11, 2026 12:39
@jason-famedly jason-famedly requested a review from a team as a code owner March 11, 2026 12:39
Copilot AI review requested due to automatic review settings March 11, 2026 12:52
@jason-famedly jason-famedly force-pushed the tt/famedly-control-docker branch from bc0c36b to 5f21efd Compare March 11, 2026 12:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@jason-famedly jason-famedly force-pushed the tt/famedly-control-docker branch from 5f21efd to 14dbea1 Compare March 11, 2026 12:53
@jason-famedly jason-famedly force-pushed the tt/famedly-control-docker branch from 14dbea1 to e09b1a5 Compare March 11, 2026 13:18
@jason-famedly jason-famedly enabled auto-merge March 11, 2026 13:35
@jason-famedly jason-famedly added this pull request to the merge queue Mar 11, 2026
Merged via the queue into master with commit 1b183e7 Mar 11, 2026
39 of 40 checks passed
@jason-famedly jason-famedly deleted the tt/famedly-control-docker branch March 11, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants