Open
Conversation
Add Dependency and start
Replace more did classes
Replace the manual $wp_filesystem->dirlist() loop and get_file_data() calls with PluginHeaderParser::parse() from did-manager-wordpress. The parser handles both file and directory paths, finding the main plugin file and extracting the Plugin ID header automatically.
remove unused phpcs blocker
Contributor
afragen
reviewed
Mar 28, 2026
| const PLUGIN_DIR = __DIR__; | ||
| const PLUGIN_FILE = __FILE__; | ||
|
|
||
| require_once __DIR__ . '/vendor/autoload.php'; |
Contributor
There was a problem hiding this comment.
There's no vendor/ committed so we'll need to either include it or...
Member
Author
There was a problem hiding this comment.
It will come from composer install.
Contributor
There was a problem hiding this comment.
And where does composer install happen? I don't see it in the releases.yml.
Member
Author
There was a problem hiding this comment.
Will add it. Since the composer.json was already there, I expected the release action would already have the process.
Add vendor folder to release asset. PS : Need to test this in a dummy release to confirm proper working.
Contributor
|
Just reminding myself: add a reusable (copy-paste) check in the plugin load process to check for vendor/ or existing autoloader, and render a friendly hint in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to DID Manager