Handle search space decode failures in _query_historical_experiments_given_parameters (#5147)#5147
Open
sdaulton wants to merge 1 commit intofacebook:mainfrom
Open
Handle search space decode failures in _query_historical_experiments_given_parameters (#5147)#5147sdaulton wants to merge 1 commit intofacebook:mainfrom
sdaulton wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5147 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 613 613
Lines 68345 68385 +40
=======================================
+ Hits 65880 65920 +40
Misses 2465 2465 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meta-codesync
bot
changed the title
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Apr 6, 2026
…given_parameters (facebook#5147) Summary: `_query_historical_experiments_given_parameters` could fail entirely if any single historical experiment had a corrupt or incompatible search space that couldn't be decoded. This wraps the `decoder.search_space_from_sqa` call in a try-except so that decode failures for individual experiments are logged as warnings and return `None` for the search space, allowing the remaining experiments to be returned successfully. Differential Revision: D98981525
sdaulton
force-pushed
the
export-D98981525
branch
from
7556b68 to
97baba8
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Apr 6, 2026
…given_parameters (facebook#5147) Summary: Pull Request resolved: facebook#5147 `_query_historical_experiments_given_parameters` could fail entirely if any single historical experiment had a corrupt or incompatible search space that couldn't be decoded. This wraps the `decoder.search_space_from_sqa` call in a try-except so that decode failures for individual experiments are logged as warnings and return `None` for the search space, allowing the remaining experiments to be returned successfully. Differential Revision: D98981525
sdaulton
force-pushed
the
export-D98981525
branch
from
97baba8 to
9e7aa56
Compare
sdaulton
added a commit
to sdaulton/Ax-1
that referenced
this pull request
Apr 6, 2026
…given_parameters (facebook#5147) Summary: `_query_historical_experiments_given_parameters` could fail entirely if any single historical experiment had a corrupt or incompatible search space that couldn't be decoded. This wraps the `decoder.search_space_from_sqa` call in a try-except so that decode failures for individual experiments are logged as warnings and return `None` for the search space, allowing the remaining experiments to be returned successfully. Differential Revision: D98981525
sdaulton
force-pushed
the
export-D98981525
branch
from
9e7aa56 to
7dc9da9
Compare
…given_parameters (facebook#5147) Summary: Pull Request resolved: facebook#5147 `_query_historical_experiments_given_parameters` could fail entirely if any single historical experiment had a corrupt or incompatible search space that couldn't be decoded. This wraps the `decoder.search_space_from_sqa` call in a try-except so that decode failures for individual experiments are logged as warnings and return `None` for the search space, allowing the remaining experiments to be returned successfully. Differential Revision: D98981525
sdaulton
force-pushed
the
export-D98981525
branch
from
7dc9da9 to
244f476
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
_query_historical_experiments_given_parameterscould fail entirely if any singlehistorical experiment had a corrupt or incompatible search space that couldn't be
decoded. This wraps the
decoder.search_space_from_sqacall in a try-except sothat decode failures for individual experiments are logged as warnings and return
Nonefor the search space, allowing the remaining experiments to be returnedsuccessfully.
Differential Revision: D98981525