Reorder TL eligibility message: action before caution#5146
Closed
lena-kashtelyan wants to merge 1 commit intofacebook:mainfrom
Closed
Reorder TL eligibility message: action before caution#5146lena-kashtelyan wants to merge 1 commit intofacebook:mainfrom
lena-kashtelyan wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Apply self-review suggestion from D97489418: move the actionable instructions (UI button / `Client.add_transferable_experiment`) before the caution text so users see what to do first, then the warning. Cleaned-up version of D97553476 — excludes accidental merge changes to generation_node.py and test_generation_node.py. Reviewed By: shrutipatel31 Differential Revision: D99385259
meta-cla
bot
added
the
CLA Signed
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99385259. |
|
This pull request has been merged in 96cf12b. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5146 +/- ##
==========================================
- Coverage 96.39% 96.38% -0.01%
==========================================
Files 613 613
Lines 68295 68295
==========================================
- Hits 65830 65829 -1
- Misses 2465 2466 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Apply self-review suggestion from D97489418: move the actionable
instructions (UI button /
Client.add_transferable_experiment) beforethe caution text so users see what to do first, then the warning.
Cleaned-up version of D97553476 — excludes accidental merge changes to
generation_node.py and test_generation_node.py.
Reviewed By: shrutipatel31
Differential Revision: D99385259