Skip to content

Add RunnerConfig typed configuration infrastructure#5131

Open
Cesar-Cardoso wants to merge 2 commits intofacebook:mainfrom
Cesar-Cardoso:export-D99150292
Open

Add RunnerConfig typed configuration infrastructure#5131
Cesar-Cardoso wants to merge 2 commits intofacebook:mainfrom
Cesar-Cardoso:export-D99150292

Conversation

@Cesar-Cardoso
Copy link
Copy Markdown
Contributor

Summary: Introduce RunnerConfig base class in runner.py with nested SearchSpaceUpdateArguments and RunnerUpdateArguments frozen dataclasses, and a config_type ClassVar on Runner so each runner subclass can declare its config type.

Reviewed By: andycylmeta

Differential Revision: D99150292

Summary: Add UNSET sentinel class in ax/utils/common/sentinel.py for distinguishing "not provided" from None in runner config updates

Reviewed By: andycylmeta

Differential Revision: D97988143
Summary: Introduce `RunnerConfig` base class in `runner.py` with nested `SearchSpaceUpdateArguments` and `RunnerUpdateArguments` frozen dataclasses, and a `config_type` ClassVar on `Runner` so each runner subclass can declare its config type.

Reviewed By: andycylmeta

Differential Revision: D99150292
@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 2, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Apr 2, 2026

@Cesar-Cardoso has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99150292.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.40%. Comparing base (4ebc621) to head (b298f8e).

Files with missing lines Patch % Lines
ax/utils/common/sentinel.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5131      +/-   ##
==========================================
- Coverage   96.40%   96.40%   -0.01%     
==========================================
  Files         613      614       +1     
  Lines       68171    68184      +13     
==========================================
+ Hits        65721    65730       +9     
- Misses       2450     2454       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Cesar-Cardoso added a commit to Cesar-Cardoso/Ax that referenced this pull request Apr 3, 2026
Summary:

Introduce `RunnerConfig` base class in `runner.py` with nested `SearchSpaceUpdateArguments` and `RunnerUpdateArguments` frozen dataclasses, and a `config_type` ClassVar on `Runner` so each runner subclass can declare its config type.

Reviewed By: andycylmeta

Differential Revision: D99150292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants