Enable BestTrials for Online Experiments#5129
Open
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Open
Enable BestTrials for Online Experiments#5129shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Pass use_model_predictions=has_batch_trials to BestTrials in ResultsAnalysis. Online experiments (which use BatchTrials) get GP model predictions for noise smoothing via shrinkage. AutoML and other direct callers get the default (False). Per design meeting 3/26: 'If online experiment, set model_predictions=True. If AutoML, say False. Set based on if has batch trials or not. For now.' --- > Generated by [Metamate](https://fb.workplace.com/groups/metamate.feedback/) [Metamate Session](https://internalfb.com/intern/bunny?q=eggmate%20f5ba8eb9-b3ef-4a16-86ce-18bb5271aff5), [Trace](https://www.internalfb.com/confucius?session_id=f5ba8eb9-b3ef-4a16-86ce-18bb5271aff5&tab=Trace) Differential Revision: D99128865
meta-cla
bot
added
the
CLA Signed
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99128865. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5129 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 613 613
Lines 68171 68193 +22
=======================================
+ Hits 65721 65743 +22
Misses 2450 2450 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Pass use_model_predictions=has_batch_trials to BestTrials in ResultsAnalysis.
Online experiments (which use BatchTrials) get GP model predictions for noise smoothing via shrinkage. AutoML and other direct callers get the default (False).
Per design meeting 3/26: 'If online experiment, set model_predictions=True. If AutoML, say False. Set based on if has batch trials or not. For now.'
Differential Revision: D99128865