Improve validate_applicable_state error messages - High Priority Updates (#5126)#5126
Open
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Open
Improve validate_applicable_state error messages - High Priority Updates (#5126)#5126shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97528392. |
…tes (facebook#5126) Summary: Fix actively misleading or broken NotApplicableState error messages across ax/analysis: - **utils.py**: Replace raw Python kwarg f-string syntax ({trial_indices=}, {trial_statuses=}) with readable key=value output in `validate_experiment_has_trials` messages - **utils.py**: Remove raw Adapter repr ({adapter}) from `validate_adapter_can_predict` messages; replace with user-readable text - **best_trials.py**: Replace backtick-quoted class names (`OptimizationConfig`, `GenerationStrategy`) with plain-language descriptions and actionable steps - **sensitivity.py**: Replace opaque "`TorchAdapter` is required." with a message explaining what the user needs to do - **top_surfaces.py**: Remove {type(relevant_adapter)} type repr; replace with plain-language message matching `sensitivity.py` - **marginal_effects.py**: Fix typo "but got.'" (missing space before quote) and remove {type(parameter).`__name__`} internal class name from error message - **objective_p_feasible_frontier.py**: Fix "Optimization_config" underscore bug (should read "optimization config"), and replace raw Adapter repr ({relevant_adapter}, {relevant_adapter.generator}) with `__name__` type strings Differential Revision: D97528392
aef95ef to
7e7a781
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix actively misleading or broken NotApplicableState error messages across ax/analysis:
validate_experiment_has_trialsmessagesvalidate_adapter_can_predictmessages; replace with user-readable textOptimizationConfig,GenerationStrategy) with plain-language descriptions and actionable stepsTorchAdapteris required." with a message explaining what the user needs to dosensitivity.py__name__} internal class name from error message__name__type stringsDifferential Revision: D97528392