Bump MAX_VALUES_CHOICE_PARAM from 1000 to 1001 (#5116)#5116
Open
Cesar-Cardoso wants to merge 1 commit intofacebook:mainfrom
Open
Bump MAX_VALUES_CHOICE_PARAM from 1000 to 1001 (#5116)#5116Cesar-Cardoso wants to merge 1 commit intofacebook:mainfrom
Cesar-Cardoso wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@Cesar-Cardoso has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98747907. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5116 +/- ##
==========================================
- Coverage 96.40% 96.40% -0.01%
==========================================
Files 613 613
Lines 68142 68142
==========================================
- Hits 65694 65693 -1
- Misses 2448 2449 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: ## Summary: Bump `MAX_VALUES_CHOICE_PARAM` from 1000 to 1001 in Ax `ChoiceParameter` to fix GitHub issue facebook/Ax facebook#5108. Users commonly want to split [0, 1] in 0.001 steps, yielding 1001 elements. The previous limit of 1000 blocked this natural use case. Updated the constant in `parameter.py` and adjusted 3 test values in `test_parameter.py` to match the new limit. Internal --- ## Instructions about RACER Diffs: **Commandeer this diff (recommended) or land with accept2ship tag.** **This diff was generated by Racer AI agent on behalf of [Cesar Cardoso](https://www.internalfb.com/profile/view/100028184453680) for T262124460. If the diff quality is poor, consider contacting the user to provide clearer instructions on the task.** - If you are happy with the changes, commandeer it if minor edits are needed. (**we encourage commandeer to get the diff credit**) - If you are not happy with the changes, please comment on the diff with clear actions and send it back to the author. Racer will pick it up and re-generate. - If you really feel the Racer is not helping with this change (alas, some complex changes are hard for AI) feel free to abandon this diff. - **For M10N reviewers:** as you review AI-generated diffs, we ask you to give them the same priority as human-generated diffs, and take action in a timely manner by either accepting, rejecting, or resigning as a reviewer. For diffs that don't meet the quality bar (e.g. code doesn't compile, not readable or introduces functionality regressions), we ask that you use the following hashtags to provide clear signals to improve our tools - `#monlowqualitydiff` `#monwrongreviewerdiff` --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=f5214618-2c52-11f1-b857-dd63b4a9f85c&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=f5214618-2c52-11f1-b857-dd63b4a9f85c&tab=Trace) Reviewed By: Cesar-Cardoso Differential Revision: D98747907
f4ee43b to
c618f26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Summary:
Bump
MAX_VALUES_CHOICE_PARAMfrom 1000 to 1001 in AxChoiceParameterto fix GitHub issue facebook/Ax #5108.Users commonly want to split [0, 1] in 0.001 steps, yielding 1001 elements. The previous limit of 1000 blocked this natural use case. Updated the constant in
parameter.pyand adjusted 3 test values intest_parameter.pyto match the new limit.Internal
Instructions about RACER Diffs:
Commandeer this diff (recommended) or land with accept2ship tag.
This diff was generated by Racer AI agent on behalf of Cesar Cardoso for T262124460. If the diff quality is poor, consider contacting the user to provide clearer instructions on the task.
#monlowqualitydiff#monwrongreviewerdiffReviewed By: Cesar-Cardoso
Differential Revision: D98747907