Skip to content

Bump MAX_VALUES_CHOICE_PARAM from 1000 to 1001 (#5116)#5116

Open
Cesar-Cardoso wants to merge 1 commit intofacebook:mainfrom
Cesar-Cardoso:export-D98747907
Open

Bump MAX_VALUES_CHOICE_PARAM from 1000 to 1001 (#5116)#5116
Cesar-Cardoso wants to merge 1 commit intofacebook:mainfrom
Cesar-Cardoso:export-D98747907

Conversation

@Cesar-Cardoso
Copy link
Copy Markdown
Contributor

@Cesar-Cardoso Cesar-Cardoso commented Mar 31, 2026

Summary:

Summary:

Bump MAX_VALUES_CHOICE_PARAM from 1000 to 1001 in Ax ChoiceParameter to fix GitHub issue facebook/Ax #5108.

Users commonly want to split [0, 1] in 0.001 steps, yielding 1001 elements. The previous limit of 1000 blocked this natural use case. Updated the constant in parameter.py and adjusted 3 test values in test_parameter.py to match the new limit.

Internal

Instructions about RACER Diffs:

Commandeer this diff (recommended) or land with accept2ship tag.

This diff was generated by Racer AI agent on behalf of Cesar Cardoso for T262124460. If the diff quality is poor, consider contacting the user to provide clearer instructions on the task.

  • If you are happy with the changes, commandeer it if minor edits are needed. (we encourage commandeer to get the diff credit)
  • If you are not happy with the changes, please comment on the diff with clear actions and send it back to the author. Racer will pick it up and re-generate.
  • If you really feel the Racer is not helping with this change (alas, some complex changes are hard for AI) feel free to abandon this diff.
  • For M10N reviewers: as you review AI-generated diffs, we ask you to give them the same priority as human-generated diffs, and take action in a timely manner by either accepting, rejecting, or resigning as a reviewer. For diffs that don't meet the quality bar (e.g. code doesn't compile, not readable or introduces functionality regressions), we ask that you use the following hashtags to provide clear signals to improve our tools - #monlowqualitydiff #monwrongreviewerdiff

Generated by RACER, powered by Confucius
Session, Trace

Reviewed By: Cesar-Cardoso

Differential Revision: D98747907

@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Mar 31, 2026

@Cesar-Cardoso has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98747907.

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 31, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.40%. Comparing base (6cebd1c) to head (c618f26).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5116      +/-   ##
==========================================
- Coverage   96.40%   96.40%   -0.01%     
==========================================
  Files         613      613              
  Lines       68142    68142              
==========================================
- Hits        65694    65693       -1     
- Misses       2448     2449       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Summary:

 ## Summary:
Bump `MAX_VALUES_CHOICE_PARAM` from 1000 to 1001 in Ax `ChoiceParameter` to fix GitHub issue facebook/Ax facebook#5108.

Users commonly want to split [0, 1] in 0.001 steps, yielding 1001 elements. The previous limit of 1000 blocked this natural use case. Updated the constant in `parameter.py` and adjusted 3 test values in `test_parameter.py` to match the new limit.

Internal
---
## Instructions about RACER Diffs:
**Commandeer this diff (recommended) or land with accept2ship tag.**

**This diff was generated by Racer AI agent on behalf of [Cesar Cardoso](https://www.internalfb.com/profile/view/100028184453680) for T262124460. If the diff quality is poor, consider contacting the user to provide clearer instructions on the task.**

- If you are happy with the changes, commandeer it if minor edits are needed. (**we encourage commandeer to get the diff credit**)
- If you are not happy with the changes, please comment on the diff with clear actions and send it back to the author. Racer will pick it up and re-generate.
- If you really feel the Racer is not helping with this change (alas, some complex changes are hard for AI) feel free to abandon this diff.
- **For M10N reviewers:** as you review AI-generated diffs, we ask you to give them the same priority as human-generated diffs, and take action in a timely manner by either accepting, rejecting, or resigning as a reviewer. For diffs that don't meet the quality bar (e.g. code doesn't compile, not readable or introduces functionality regressions), we ask that you use the following hashtags to provide clear signals to improve our tools - `#monlowqualitydiff` `#monwrongreviewerdiff`
---
> Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/)
[Session](https://www.internalfb.com/confucius?session_id=f5214618-2c52-11f1-b857-dd63b4a9f85c&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=f5214618-2c52-11f1-b857-dd63b4a9f85c&tab=Trace)

Reviewed By: Cesar-Cardoso

Differential Revision: D98747907
@meta-codesync meta-codesync bot changed the title Bump MAX_VALUES_CHOICE_PARAM from 1000 to 1001 Bump MAX_VALUES_CHOICE_PARAM from 1000 to 1001 (#5116) Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants