Skip to content

Update subtitle rendering in notebook Analysis Cards (#5112) #5112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shrutipatel31 wants to merge 1 commit into
base: main
Choose a base branch
from
+52 −18
Open

Update subtitle rendering in notebook Analysis Cards (#5112) #5112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 52 additions & 18 deletions ax/core/analysis_card.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@
from plotly.offline import get_plotlyjs

# Simple HTML template for rendering a card with a title, subtitle, and body with
# scrollable overflow.
# scrollable overflow. Subtitles are rendered in a <div> with max-height overflow
# so that any HTML content (tables, lists, etc.) is valid and clipped correctly
# in the collapsed state. A "See more"/"See less" toggle appears when content
# overflows (matching the web UI pattern).
html_card_template = """
<style>
.card {{
Expand All @@ -30,34 +33,65 @@
border-radius: 0.5em;
padding: 10px;
}}
.card-header:hover {{
cursor: pointer;
}}
.card-header details summary {{
list-style: none;
display: inline-flex;
align-items: center;
gap: 0.5em;
.card-subtitle {{
color: gray;
font-size: 0.9em;
margin: 4px 0 0 0;
line-height: 1.4em;
max-height: 1.4em;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
}}
.card-header details summary::-webkit-details-marker {{
.card-subtitle-toggle {{
color: #1877F2;
cursor: pointer;
font-size: 0.85em;
background: none;
border: none;
padding: 0;
margin-top: 2px;
display: none;
}}
.card-header details summary::after {{
content: "ℹ️";
font-size: 0.9em;
}}
</style>
<div class="card">
<div class="card-header">
<details>
<summary><b>{title_str}</b></summary>
<p>{subtitle_str}</p>
</details>
<b>{title_str}</b>
<div class="card-subtitle">{subtitle_str}</div>
<button class="card-subtitle-toggle">See more</button>
</div>
<div class="card-body">
{body_html}
</div>
</div>
<script>
(function() {{
var card = document.currentScript.previousElementSibling;
var subtitle = card.querySelector('.card-subtitle');
var toggle = card.querySelector('.card-subtitle-toggle');
if (subtitle && toggle) {{
requestAnimationFrame(function() {{
if (subtitle.scrollHeight > subtitle.clientHeight
|| subtitle.scrollWidth > subtitle.clientWidth) {{
toggle.style.display = 'inline';
}}
}});
toggle.onclick = function() {{
if (subtitle.style.maxHeight === 'none') {{
subtitle.style.maxHeight = '1.4em';
subtitle.style.whiteSpace = 'nowrap';
subtitle.style.textOverflow = 'ellipsis';
toggle.textContent = 'See more';
}} else {{
subtitle.style.maxHeight = 'none';
subtitle.style.whiteSpace = 'normal';
subtitle.style.textOverflow = 'clip';
toggle.textContent = 'See less';
}}
}};
}}
}})();
</script>
"""

# Simple HTML template for rendering a *group* card with a title, subtitle, and
Expand Down
Loading