Handle missing params in analysis comment interpolation #8495
+22
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace String#% with gsub-based interpolation that defaults missing template keys to empty string instead of raising KeyError. This prevents noisy Sentry alerts when analyzer templates reference params not provided in the analysis output. Closes #8486 Closes #8487 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8486
Closes #8487
Summary
String#%withgsub-based interpolation inSubmission::Analysis#commentsfor rendering analyzer comment templates%{mentoring_request_url}) now default to empty string instead of raisingKeyError%%escape sequences are still correctly converted to literal%Test plan
%%escaping tests)🤖 Generated with Claude Code