-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add keys only range test cases #21247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tests/common/kv_test.go
Outdated
| } | ||
| } | ||
|
|
||
| dropValue := func(s []*mvccpb.KeyValue) []*mvccpb.KeyValue { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be anonymous function? Could we just move it to normal function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto for all other functions in the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 27 files with indirect coverage changes @@ Coverage Diff @@
## main #21247 +/- ##
==========================================
+ Coverage 68.41% 68.44% +0.03%
==========================================
Files 429 429
Lines 35288 35291 +3
==========================================
+ Hits 24142 24155 +13
Misses 9751 9751
+ Partials 1395 1385 -10 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
3ad40d4 to
d200ba4
Compare
f9d6c0a to
7fec54e
Compare
|
Please fix Personally I don't agree with this change, prefer explicit parameters for functions even it's used with same argument. You can disable unparam for this line |
Signed-off-by: Nont <nont@duck.com>
7fec54e to
ec3114e
Compare
|
Added no lint for the func now. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nwnt, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@nwnt: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add keys only range test cases Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Breaking #21229 down. This PR makes all range test cases do --keys-only tests.
cc @serathius