Skip to content

Conversation

@nwnt
Copy link
Member

@nwnt nwnt commented Feb 3, 2026

Breaking #21229 down. This PR makes all range test cases do --keys-only tests.

cc @serathius

}
}

dropValue := func(s []*mvccpb.KeyValue) []*mvccpb.KeyValue {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be anonymous function? Could we just move it to normal function?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto for all other functions in the test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.44%. Comparing base (d89978e) to head (ec3114e).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files

see 27 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21247      +/-   ##
==========================================
+ Coverage   68.41%   68.44%   +0.03%     
==========================================
  Files         429      429              
  Lines       35288    35291       +3     
==========================================
+ Hits        24142    24155      +13     
  Misses       9751     9751              
+ Partials     1395     1385      -10     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d89978e...ec3114e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nwnt nwnt force-pushed the add-range-test-keys-only branch from 3ad40d4 to d200ba4 Compare February 4, 2026 02:41
@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Feb 4, 2026
@nwnt nwnt force-pushed the add-range-test-keys-only branch 2 times, most recently from f9d6c0a to 7fec54e Compare February 4, 2026 02:46
@serathius
Copy link
Member

serathius commented Feb 4, 2026

Please fix

../tests/common/kv_test.go:180:61: createHeader - offset always receives 7 (unparam)
func createHeader(firstHeader *etcdserverpb.ResponseHeader, offset int64) *etcdserverpb.ResponseHeader {

Personally I don't agree with this change, prefer explicit parameters for functions even it's used with same argument. You can disable unparam for this line

Signed-off-by: Nont <nont@duck.com>
@nwnt nwnt force-pushed the add-range-test-keys-only branch from 7fec54e to ec3114e Compare February 4, 2026 11:54
@nwnt
Copy link
Member Author

nwnt commented Feb 4, 2026

Added no lint for the func now.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nwnt, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

@nwnt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-coverage-report ec3114e link true /test pull-etcd-coverage-report

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@serathius serathius merged commit 7c22682 into etcd-io:main Feb 4, 2026
32 of 33 checks passed
dims pushed a commit to dims/etcd that referenced this pull request Feb 5, 2026
Add keys only range test cases

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants