tests:make robustness report id match log id by madhav-murali · Pull Request #21228 · etcd-io/etcd

madhav-murali · 2026-01-31T16:27:22Z

Fixes #21211
This PR updates the MemberID JSON marshaling to use hexadecimal format (instead of decimal) in the robustness report. This ensures that the member-id in operations.json matches the format used in logs.

I haven't added unit tests, because I wasn't sure. Ran make test-robustness and verified with the operations.json file to ensure member-id matched.
Signed-off-by: Madhav Murali mdvmrli@gmail.com

k8s-ci-robot · 2026-01-31T16:27:32Z

Hi @madhav-murali. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

nwnt · 2026-01-31T17:07:36Z

tests/robustness/model/types.go


+type MemberID uint64
+
+// MarshallJson implements the json.Marshaler interface for MemberID.


nit: inconsistent with the func name and not rhyme.

Fixed the typo, thanks

nwnt · 2026-02-01T06:33:38Z

tests/robustness/model/types.go

+func (m MemberID) MarshalJSON() ([]byte, error) {
+	return json.Marshal(fmt.Sprintf("%x", m))
+}


I'm not sure if this is correct though. This looks like we're just converting uint64 into a hex value. Have you tested this that the values actually match?

Yeah i did confirm that the MemberID's generated in the operations.json file appear in the server logs in hexa format.

sounds good.

serathius · 2026-02-01T16:55:58Z

/ok-to-test

Please add tests comparing output of model and type.ID

codecov · 2026-02-01T17:37:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.40%. Comparing base (d89978e) to head (d6edb51).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21228      +/-   ##
==========================================
- Coverage   68.41%   68.40%   -0.02%     
==========================================
  Files         429      429              
  Lines       35288    35288              
==========================================
- Hits        24142    24137       -5     
- Misses       9751     9755       +4     
- Partials     1395     1396       +1

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d89978e...d6edb51. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

madhav-murali · 2026-02-01T19:43:05Z

@serathius, I have added unit test in member_test.go. Is it ok?

madhav-murali · 2026-02-02T04:30:35Z

/retest

serathius · 2026-02-02T09:15:35Z

tests/robustness/model/types_test.go

Test for types.go struct should be in types_test.go

serathius · 2026-02-02T09:16:33Z

tests/robustness/model/types_test.go

+
+	tID := types.ID(raw)
+	expectedHex := tID.String()
+	require.JSONEq(t, "\""+expectedHex+"\"", jsonStr)


Please parse it out

(⊙ _ ⊙ ) Forgot the Unmarshaler interface. :S

I've added UnmarshalJSON and included a round-trip test in types_test.go to ensure everything parses back correctly.

madhav-murali · 2026-02-02T12:33:37Z

/retest

serathius · 2026-02-02T12:42:06Z

tests/robustness/model/history.go

 	}
 	var revision int64
-	var MemberID uint64
+	var memberID uint64


Suggested change

var memberID uint64

var memberID MemberID

serathius · 2026-02-02T12:42:17Z

tests/robustness/model/history.go

+		memberID = resp.Header.MemberId
 	}
-	h.appendSuccessful(request, start, end, putResponseWithMemberID(revision, MemberID))
+	h.appendSuccessful(request, start, end, putResponseWithMemberID(revision, MemberID(memberID)))


Suggested change

h.appendSuccessful(request, start, end, putResponseWithMemberID(revision, MemberID(memberID)))

h.appendSuccessful(request, start, end, putResponseWithMemberID(revision, memberID))

serathius · 2026-02-02T12:48:59Z

tests/robustness/model/types.go

+		return err
+	}
+
+	id, err := types.IDFromString(s)


If we are using IDFromString, for unmarshall we should use symmetrical function during Marshaling. If there is none, we should add it. Expect we should use types.Id(m).String() instead of fmt.Sprintf("%x", m)

Ok, I have corrected the asymmetrical implementations using types.Id(m).String() instead of the current one. I've also use MemberID in types.go for type-safety.
Thanks for the guidance :)

Signed-off-by: Madhav Murali <mdvmrli@gmail.com>

serathius · 2026-02-02T13:30:37Z

tests/robustness/model/history.go

@@ -70,7 +70,7 @@ func (h *AppendableHistory) AppendRange(startKey, endKey string, revision, limit
 		respRevision = resp.Header.Revision
 		respMemberID = resp.Header.MemberId


Suggested change

respMemberID = resp.Header.MemberId

respMemberID = MemberID(resp.Header.MemberId)

serathius · 2026-02-02T13:31:39Z

tests/robustness/model/history.go

 		respMemberID = resp.Header.MemberId
 	}
-	h.appendSuccessful(request, start, end, rangeResponseWithMemberID(resp.Kvs, resp.Count, respRevision, respMemberID))
+	h.appendSuccessful(request, start, end, rangeResponseWithMemberID(resp.Kvs, resp.Count, respRevision, MemberID(respMemberID)))


Suggested change

h.appendSuccessful(request, start, end, rangeResponseWithMemberID(resp.Kvs, resp.Count, respRevision, MemberID(respMemberID)))

h.appendSuccessful(request, start, end, rangeResponseWithMemberID(resp.Kvs, resp.Count, respRevision, respMemberID))

k8s-ci-robot · 2026-02-02T13:36:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: madhav-murali, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

madhav-murali · 2026-02-02T14:23:41Z

/retest

k8s-ci-robot added area/robustness-testing area/testing needs-ok-to-test labels Jan 31, 2026

k8s-ci-robot added the size/M label Jan 31, 2026

madhav-murali mentioned this pull request Jan 31, 2026

Make robustness report and its log show consistent member-id #21211

Open

nwnt reviewed Jan 31, 2026

View reviewed changes

madhav-murali force-pushed the feat/member-id-report-fix branch from 02c34b4 to decc822 Compare January 31, 2026 17:30

nwnt reviewed Feb 1, 2026

View reviewed changes

madhav-murali requested a review from nwnt February 1, 2026 16:22

k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels Feb 1, 2026

madhav-murali force-pushed the feat/member-id-report-fix branch from decc822 to 47c401a Compare February 1, 2026 19:24

k8s-ci-robot added size/L and removed size/M labels Feb 1, 2026

serathius reviewed Feb 2, 2026

View reviewed changes

tests/robustness/model/types_test.go

Copy link

Member

serathius Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for types.go struct should be in types_test.go

madhav-murali reacted with thumbs up emoji

serathius reviewed Feb 2, 2026

View reviewed changes

madhav-murali force-pushed the feat/member-id-report-fix branch from 47c401a to 72f0165 Compare February 2, 2026 11:12

serathius reviewed Feb 2, 2026

View reviewed changes

tests:make robustness report id match log id

d6edb51

Signed-off-by: Madhav Murali <mdvmrli@gmail.com>

madhav-murali force-pushed the feat/member-id-report-fix branch from 72f0165 to d6edb51 Compare February 2, 2026 13:20

serathius reviewed Feb 2, 2026

View reviewed changes

serathius approved these changes Feb 2, 2026

View reviewed changes

k8s-ci-robot added the approved label Feb 2, 2026


		type MemberID uint64

		// MarshallJson implements the json.Marshaler interface for MemberID.

	h.appendSuccessful(request, start, end, putResponseWithMemberID(revision, MemberID(memberID)))
	h.appendSuccessful(request, start, end, putResponseWithMemberID(revision, memberID))

		@@ -70,7 +70,7 @@ func (h *AppendableHistory) AppendRange(startKey, endKey string, revision, limit
		respRevision = resp.Header.Revision
		respMemberID = resp.Header.MemberId

	respMemberID = resp.Header.MemberId
	respMemberID = MemberID(resp.Header.MemberId)

Conversation

madhav-murali commented Jan 31, 2026

Uh oh!

k8s-ci-robot commented Jan 31, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

serathius commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

madhav-murali commented Feb 1, 2026

Uh oh!

madhav-murali commented Feb 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madhav-murali commented Feb 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Feb 2, 2026

Uh oh!

madhav-murali commented Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

serathius commented Feb 1, 2026 •

edited

Loading

codecov bot commented Feb 1, 2026 •

edited

Loading