Skip to content

etcdutl: add cases to hashkv_command_test#21201

Open
silentred wants to merge 1 commit intoetcd-io:mainfrom
silentred:etcdutl
Open

etcdutl: add cases to hashkv_command_test#21201
silentred wants to merge 1 commit intoetcd-io:mainfrom
silentred:etcdutl

Conversation

@silentred
Copy link
Contributor

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

The root cause in #21106 is that when there are keys with leases in db, the recovering process of store panics at https://github.com/etcd-io/etcd/blob/main/server/storage/mvcc/kvstore.go#L395 , before attaching keys to leases.
Therefore, I added a case to hashkv_command_test for the scenario described above.
cc @fuweid @ahrtr @serathius

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: silentred
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @silentred. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: shenmu.wy <shenmu.wy@antfin.com>
@silentred silentred changed the title add cases to hashkv_command_test etcdutl: add cases to hashkv_command_test Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants