Bind hopper eject to driver right bumper, and keep operator eject as X. #83
Closed
Bind hopper eject to driver right bumper, and keep operator eject as X. #83
Conversation
themehdev
added
the
should happen
|
|
||
| //While the X button is held, the intake will run the eject sequence. If it the intake is stowed, it will also deploy it. | ||
| //While the right bumper is held, the intake will run the eject sequence. If it the intake is stowed, it will also deploy it. | ||
| // Because anshu already has practice with the button being X, it is kept as X, but this can change after talking to anshu. |
Collaborator
There was a problem hiding this comment.
I would try to leave your comments about why you changed things in github comments like these. Comments are for understanding how the code is written.
Contributor
Author
There was a problem hiding this comment.
Sure. This was more of a reminder to follow up with Anshu than anything, just saying that this isn't final yet. I will remove it when I do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operator one can be changed, but I figured anshu already had practice with the button being X, so I kept it that way.