Fix: Prevent query parameter corruption in base_url #3760
+46
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3614
When a
base_urlcontains query parameters, the trailing slash enforcement was corrupting the query parameter values by appending the slash to the query string instead of just the path.Problem
The
_enforce_trailing_slash()method was appending/to the entireraw_path, which includes both the path and query string. For a URL like/get?data=1, this became/get?data=1/, corrupting the query parameter value.Solution
Modified
_enforce_trailing_slash()in_client.pyto:raw_pathinto path and query components (using?as delimiter)Examples
base_url with query parameters:
base_url with trailing slash and query:
base_url without query (unchanged behavior):
Testing
tests/client/test_client.py