fix(blog): use getSiteSettings() instead of hardcoded site title#3
Open
tgfjt wants to merge 2 commits intoemdash-cms:mainfrom
Open
fix(blog): use getSiteSettings() instead of hardcoded site title#3tgfjt wants to merge 2 commits intoemdash-cms:mainfrom
tgfjt wants to merge 2 commits intoemdash-cms:mainfrom
Conversation
Replace hardcoded "My Blog" title and tagline across blog and blog-cloudflare templates with dynamic values from getSiteSettings(), so that changes made in the admin Settings panel are reflected on the site.
Match the settings?.title || "fallback" pattern used in portfolio and marketing templates instead of settings.title ?? "fallback".
tgfjt
force-pushed
the
fix/blog-use-site-settings
branch
from
45e539d to
1b839a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for building this — it's really cool. I've been trying it out!
Summary
"My Blog"title and"Thoughts, stories, and ideas."tagline with dynamic values fromgetSiteSettings()in both blog/ and blog-cloudflare/ templatessettings?.title || "fallback"pattern already used in portfolio, portfolio-cloudflare, marketing, and marketing-cloudflare templatesChanged files (4 per template × 2 templates = 8 files)
src/layouts/Base.astrogetSiteSettings, replace hardcoded title/taglinesrc/pages/index.astrogetSiteSettings, use dynamic title/descriptionsrc/pages/posts/[slug].astrogetSiteSettings, use dynamic siteTitle ingetSeoMeta()src/pages/rss.xml.tsgetSiteSettings, fetch title/description inside GET handlerNot changed (already using
getSiteSettings())Test plan
npx emdash dev)<title>tag, RSS feed