fix(admin): auto-fetch API pages when paginating content list#273
Open
all3f0r1 wants to merge 2 commits intoemdash-cms:mainfrom
Open
fix(admin): auto-fetch API pages when paginating content list#273all3f0r1 wants to merge 2 commits intoemdash-cms:mainfrom
all3f0r1 wants to merge 2 commits intoemdash-cms:mainfrom
Conversation
The content list only displayed the first batch of items from the API (up to 100). Client-side pagination cycled through those items but never fetched additional pages via nextCursor, making items beyond the first batch invisible. Replace the manual "Load More" button with an effect that automatically triggers fetchNextPage() when the user reaches the last client-side page and more API data is available. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 6c38d93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
i found some issues:
|
Contributor
|
and of course the changeset is missing 🫠 |
Contributor
|
@ascorbic can you commit those changes?
changeset |
JULJERYT
approved these changes
Apr 6, 2026
- Add searchQuery guard to prevent spurious fetches when filtering collapses totalPages - Stabilize onLoadMore with React.useCallback to avoid effect re-fires - Add tests: navigation to last page triggers fetch, search suppresses fetch, "+" suffix on item count when hasMore is true - Add changeset Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
5 tasks
Contributor
Overlapping PRsThis PR modifies files that are also changed by other open PRs:
This may cause merge conflicts or duplicated work. A maintainer will coordinate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The admin content list only displayed the first batch of items from the API (up to 100). Client-side pagination (pages of 20) cycled through those items but never fetched additional pages via
nextCursor, making items beyond the first batch completely invisible in the admin.This replaces the manual "Load More" button with a
useEffectthat automatically triggersfetchNextPage()when the user reaches the last client-side page and more API data is available. The item count also now shows "100+" when more pages exist.Closes #266
Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
Screenshots / test output
N/A — behavioral change only (no visual changes).