fix(admin): avoid locally caught exception in PasskeyLogin#268
Merged
ascorbic merged 3 commits intoemdash-cms:mainfrom Apr 6, 2026
Merged
fix(admin): avoid locally caught exception in PasskeyLogin#268ascorbic merged 3 commits intoemdash-cms:mainfrom
ascorbic merged 3 commits intoemdash-cms:mainfrom
Conversation
Why: The passkey login flow threw an error when navigator.credentials.get() returned no credential, but that exception was immediately caught by the local catch block in the same function. This triggered a "throw of exception caught locally" warning and made the failure path less direct. What: - Handle the missing credential case inline instead of throwing locally - Preserve the existing error message shown to the user - Keep the onError callback behavior unchanged
🦋 Changeset detectedLatest commit: 1179ef1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
nice one |
JULJERYT
approved these changes
Apr 6, 2026
Contributor
|
@ascorbic could you add changeset? everything else looks good to me |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The passkey login flow threw an error when navigator.credentials.get() returned no credential, but that exception was immediately caught by the local catch block in the same function. This triggered a "throw of exception caught locally" warning and made the failure path less direct.
What:
What does this PR do?
Closes #
Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
Screenshots / test output