fix: register email settings API route (#151)#247
Open
NaeemHaque wants to merge 3 commits intoemdash-cms:mainfrom
Open
fix: register email settings API route (#151)#247NaeemHaque wants to merge 3 commits intoemdash-cms:mainfrom
NaeemHaque wants to merge 3 commits intoemdash-cms:mainfrom
Conversation
The email settings route file existed but was never registered via injectRoute(), causing the endpoint to return 404 and the admin page to render an empty pipeline container. Adds error state to the admin UI so fetch failures are visible instead of silently swallowed.
🦋 Changeset detectedLatest commit: c28bb01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The email settings route file existed but was never registered via injectRoute(), causing the endpoint to return 404 and the admin page to render an empty pipeline
container. Adds error state to the admin UI so fetch failures are visible instead of silently swallowed.
What does this PR do?
The
/_emdash/api/settings/emailAPI route file (packages/core/src/astro/routes/api/settings/email.ts) existed but was never registered inpackages/core/src/astro/integration/routes.tsviainjectRoute(). This caused the endpoint to return 404, and the admin Email Settings page silently swallowed the error— showing just the "Email Pipeline" heading with an empty body.
This PR:
routes.tsEmailSettingscomponent so failures display a visible error banner instead of an empty containerCloses #151
Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
Screenshots / test output
Test output:
✓ tests/unit/api/email-settings-route.test.ts (1 test) 9ms