fix: allow list literals in struct type parsing#111
Open
mkaput wants to merge 2 commits intoelixir-tools:mainfrom
Open
fix: allow list literals in struct type parsing#111mkaput wants to merge 2 commits intoelixir-tools:mainfrom
mkaput wants to merge 2 commits intoelixir-tools:mainfrom
Conversation
Struct type parsing skipped list-prefix expressions, causing valid forms like `%+[]{}` to error.
Handle `[` in `parse_struct_type/1` by delegating to list literal parsing, matching Elixir behavior for struct type expressions.
Adds a regression assertion in the property-regression test block.
mhanberg
force-pushed
the
mk/a57cbd-struct-type-list-literals
branch
from
3ffa4f7 to
c8a2a1d
Compare
Contributor
|
I created #113 for the property failures during the last CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Struct type parsing skipped list-prefix expressions, causing valid forms like
%+[]{}to error.Handle
[inparse_struct_type/1by delegating to list literal parsing, matching Elixir behavior for struct type expressions.Adds a regression assertion in the property-regression test block.