WIP: Adds max retries to Job#48
Open
tallysmartins wants to merge 1 commit intoelixir-bench:masterfrom
Open
Conversation
Signed-off-by: Tallys Martins <tallysmartins@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few considerations here:
Consideration 1
I've considered two ways of incrementing
claim_count, and I need feedback to know which one is more appropriate.claim_count + 1increment_claim_countwhich is binded byprepare_changesto incrementclaim_countwhen the changeset transaction is completed.From my point of view, first approach works and do not seems to present too much trouble considering possible concurrency between the runners queries.
Consideration 2
Do we need this configuration to be in the environment or something or are you ok with a module attr
@max_retries 3?