fix: remove deprecated eraseCredentials() — breaks logout on Symfony 8#111
Draft
smbpunt wants to merge 1 commit intoecphp:masterfrom
Draft
fix: remove deprecated eraseCredentials() — breaks logout on Symfony 8#111smbpunt wants to merge 1 commit intoecphp:masterfrom
smbpunt wants to merge 1 commit intoecphp:masterfrom
Conversation
`eraseCredentials()` was deprecated in Symfony 7.3 and removed in 8.0. - Remove empty `eraseCredentials()` from `CasUser` - Remove `$security->getToken()?->eraseCredentials()` call from `Logout` controller - Remove unused `Security` dependency from `Logout` controller Ref: https://symfony.com/blog/new-in-symfony-7-3-security-improvements#deprecate-erasecredentials-method
Author
|
Heads up — compatibility concern with this PR as-is. Removing How would you like to handle this @drupol ? Should I adjust the PR, or do you prefer a different approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eraseCredentials()method fromCasUser$security->getToken()?->eraseCredentials()call fromLogoutcontrollerSecuritydependency fromLogoutcontrollerContext
eraseCredentials()was deprecated in Symfony 7.3 and removed in 8.0. Sincecas-bundlenow supports Symfony 8 ("symfony/framework-bundle": "^7 || ^8"), the call in theLogoutcontroller causes a fatal error, breaking logout entirely.Ref: https://symfony.com/blog/new-in-symfony-7-3-security-improvements#deprecate-erasecredentials-method