Remove dark mode functionality and simplify palette management#899
Open
Remove dark mode functionality and simplify palette management#899
Conversation
Replace the hand-rolled dark mode system (DarkMode config key, button in
Colors setup page, custom QPalette overrides via setStyle("fusion") and
qApp->setPalette()) with Qt6's built-in platform theme integration.
- Remove SetupPageColors darkModeButton, darkMode flag, setDarkMode(),
loadDarkMode(), getDarkMode(), slotSetDarkMode(), darkModeChanged signal
- Remove SetupDialog loadDarkMode() and darkModeChanged signal chain
- Remove MainWindow setDarkMode(), slotDarkModeChanged() and DarkMode
settings read
- Replace all if(darkMode){setPalette(palWhite)}else{setPalette(palBlack)}
patterns with widget->unsetPalette() across MainWindowInputQSO,
MainWindowInputOthers, MainWindowMyDataTab, MainQSOEntryWidget,
MainWindowSatTab and SetupPageELog
- Remove palBlack and palWhite from all widget headers; keep only palRed
for validation error highlighting
KLog now respects the OS dark/light theme automatically and reacts to
theme changes at runtime via Qt6's platform integration. Closes #392.
https://claude.ai/code/session_01RR2CidMv5V9znTPtUCtuu1
|
Oh! That is a shame. I only use dark mode :( |
…ARM hamlib - elog classes were moved to src/elog/ subdirectory; update all four references (elogclublog, elogqrzlog, lotwutilities, eqslutilities) in both HEADERS and SOURCES sections - Add missing DataCache (src/database/datacache.h/.cpp) which is required by DataProxy_SQLite but was absent from the test target, causing linker errors for all DataCache methods - Add /opt/homebrew/Cellar/hamlib include/lib paths for Apple Silicon Macs alongside the existing /usr/local paths (matching src/src.pro) https://claude.ai/code/session_01RR2CidMv5V9znTPtUCtuu1
The file was named 'subdvisions' (missing 'i') instead of 'subdivisions'. Rename the file and update all references across: - src/database/db_adif_primary_sub*visions*_data.h/.cpp (renamed + include guards) - src/database/database.cpp (#include) - src/src.pro, src/CMakeLists.txt - All test .pro and CMakeLists.txt files - tests/tst_logwindow and tst_database .cpp files - .gitignore (moc_ generated file entries) https://claude.ai/code/session_01RR2CidMv5V9znTPtUCtuu1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the dark mode feature and simplifies palette management across the application by using Qt's
unsetPalette()method instead of manually managing black/white text palettes.Key Changes
Removed dark mode infrastructure: Deleted all dark mode toggle buttons, settings, and related UI from the setup dialog's color page
Simplified palette handling: Replaced conditional palette assignments (palBlack/palWhite) with
unsetPalette()calls to use system defaults for valid input statesRemoved dark mode state management: Eliminated
darkModeboolean variables andsetDarkMode()methods from:MainWindowInputQSOMainWindowInputOthersMainWindowMyDataTabMainWindowSatTabSetupPageColorsMainQSOEntryWidgetMainWindowCleaned up settings: Removed dark mode persistence from configuration files (DarkMode setting no longer saved/loaded)
Removed helper methods: Deleted
readDarkMode(),getDarkMode(), and related signal/slot connections throughout the codebaseRemoved unused palettes: Eliminated
palBlackandpalWhitepalette objects, keeping onlypalRedfor validation error statesImplementation Details
unsetPalette()to restore default appearance, invalid inputs usepalRedfor error indicationdarkModeChangedsignal that was emitted fromSetupPageColorsand connected throughout the applicationhttps://claude.ai/code/session_01RR2CidMv5V9znTPtUCtuu1