[PySpark] - Add DataFrame iterator methods and corresponding tests#381
Open
mariotaddeucci wants to merge 4 commits intoduckdb:mainfrom
Open
[PySpark] - Add DataFrame iterator methods and corresponding tests#381mariotaddeucci wants to merge 4 commits intoduckdb:mainfrom
mariotaddeucci wants to merge 4 commits intoduckdb:mainfrom
Conversation
- Implement `toLocalIterator`, `foreach`, and `foreachPartition` methods in the DataFrame class. - Add tests for `isEmpty`, `foreach`, `foreachPartition`, and `toLocalIterator` methods in the test suite.
There was a problem hiding this comment.
Pull request overview
Adds DataFrame iteration APIs to the DuckDB Spark-compat layer and expands the test suite to validate these behaviors.
Changes:
- Implement
DataFrame.toLocalIterator,DataFrame.foreach,DataFrame.foreachPartition, andDataFrame.isEmpty. - Refactor row construction into a shared helper used by both
collect()andtoLocalIterator(). - Add tests covering
isEmpty,foreach,foreachPartition, andtoLocalIterator.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/fast/spark/test_spark_dataframe.py | Adds unit tests for the new DataFrame iterator/foreach APIs and isEmpty. |
| duckdb/experimental/spark/sql/dataframe.py | Implements toLocalIterator, foreach, foreachPartition, isEmpty, and shared Row construction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+170
to
+171
| while rows := itertools.islice(rows_generator, 10_000): | ||
| f(rows) |
|
|
||
| mock_callable = mock.MagicMock() | ||
| df.foreachPartition(mock_callable) | ||
| mock_callable.assert_called_once_with(expected) |
Comment on lines
+82
to
+83
| def toLocalIterator(self, prefetchPartitions: bool = False) -> Iterator[Row]: | ||
| """Returns an iterator that contains all of the rows in this :class:`DataFrame`. |
Comment on lines
+116
to
+117
| while rows := cur.fetchmany(10_000): | ||
| yield from (_construct_row(x, columns) for x in rows) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ch to handle iterables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isEmpty,toLocalIterator,foreach, andforeachPartitionmethods in the DataFrame class.