Fix ToggleExtendedWindowStyle not working on visible = true#255
Merged
dotMorten merged 1 commit intodotMorten:mainfrom Mar 24, 2026
Merged
Fix ToggleExtendedWindowStyle not working on visible = true#255dotMorten merged 1 commit intodotMorten:mainfrom
dotMorten merged 1 commit intodotMorten:mainfrom
Conversation
This caused a lot of confusion for me.
There was a problem hiding this comment.
Pull request overview
Fixes ToggleExtendedWindowStyle so that passing visible = true correctly enables (adds) the specified extended window style flags, matching the behavior of ToggleWindowStyle and the intent of the API. This is a follow-up to PR #249, which addressed the same issue for non-extended window styles.
Changes:
- Replace an incorrect bitwise
ANDwith bitwiseORwhen enabling an extended window style flag inToggleExtendedWindowStyle.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caused a lot of confusion for me.follow-up to #249