fix: --files-only --configure now substitutes placeholders (closes #75)#76
Open
TheCodingDragon0 wants to merge 1 commit intodjdarcy:mainfrom
Open
fix: --files-only --configure now substitutes placeholders (closes #75)#76TheCodingDragon0 wants to merge 1 commit intodjdarcy:mainfrom
TheCodingDragon0 wants to merge 1 commit intodjdarcy:mainfrom
Conversation
…darcy#75) When running 'ghtraf create --files-only --configure', the configure flag was being ignored because _run_files_only dispatched immediately without checking for it. Now after deploying template files, if --configure is passed: 1. Reads .ghtraf.json from the repo directory 2. Runs configure_dashboard, configure_readme, and configure_workflow 3. Substitutes all placeholders (OWNER/REPO, PLACEHOLDER, USER/GISTID) This fixes the two-step workflow where cloud setup runs first without files existing, then --files-only copies templates but never configures them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75
Problem
When running
ghtraf create --files-only --configure, the--configureflag was ignored. The_run_files_onlyfunction dispatched immediately without checking for it, so placeholders likePLACEHOLDER,OWNER/REPO, andUSER/GISTIDwere never substituted.Root Cause
In
run(), the--files-onlycheck dispatches to_run_files_only(args)before any configure logic runs. The_run_files_onlyfunction never checkedargs.configure_files.Fix
After deploying template files in
_run_files_only, if--configureis passed:.ghtraf.jsonfrom the repo directoryconfigure_dashboard,configure_readme, andconfigure_workflowThis makes the two-step workflow work: