Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR.
| from dimos.msgs.sensor_msgs import Image | ||
| from dimos.perception.detection2d.detectors.types import Detector | ||
| from dimos.perception.detection.detectors.types import Detector | ||
| from dimos.perception.detection2d.utils import plot_results |
There was a problem hiding this comment.
The Detic detector still imports plot_results from dimos.perception.detection2d.utils, but this package was deleted in this commit when the detection code was moved under dimos.perception.detection. Loading the detector will raise ModuleNotFoundError before any inference runs. Please switch the import to the new module (or re‑add the missing helper) so the detector can be instantiated.
Useful? React with 👍 / 👎.
| def update_objects(imageDetections: ImageDetections3DPC): | ||
| for detection in imageDetections.detections: | ||
| # print(detection) | ||
| return self.add_detection(detection) |
There was a problem hiding this comment.
The update_objects callback returns after processing the first detection, so only the first object in each frame is ever added to the database. All other detections in the same ImageDetections3DPC are silently skipped, which prevents multi-object tracking from working. Drop the early return and iterate over the whole list so every detection is accumulated.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@leshy Please fix linter this makes it much harder to read PRs
There was a problem hiding this comment.
True, sorry, will check. I pinned the linter version in the repo, so weird this is happening
|
@leshy good to close |
spomichter
force-pushed
the
actual-qwen-skills2
branch
from
e7f5a90 to
92d4660
Compare
|
Too many files changed for review. |
1 similar comment
|
Too many files changed for review. |
spomichter
force-pushed
the
actual-qwen-skills2
branch
from
92d4660 to
68590e2
Compare
|
Too many files changed for review. |
spomichter
force-pushed
the
actual-qwen-skills2
branch
from
68590e2 to
e4a6d18
Compare
|
Too many files changed for review. |
6 participants
No description provided.