V3.4.0

[sbillinge]

No description provided.

[sbillinge]

@stevenhua0320 please could you look at this PR? It seems to be failing pre-commit because of an undefined variable. Also, I saw it import bareAtomLabel or something like that which we may need to deprecate?

[stevenhua0320]

@stevenhua0320 please could you look at this PR? It seems to be failing pre-commit because of an undefined variable. Also, I saw it import bareAtomLabel or something like that which we may need to deprecate?

It seems that because of my first deprecation of method assignUniqueLabels is accidentally done on the main branch at the very beginning, and at that time we don't want to cover this method again in v3.4.0 and now github identifies the difference, so it believes we delete the change on assignUniqueLabels method. So a proper fix I believe is to make the change for assignUniqueLabels also on v3.4.0 so that this method is consistent with the change we have done in main. For the bareAtomSymbol, I believe we have deprecated that method in v3.4.0, so the only change we need to make is to change the usage to bare_atom_symbol. I would make a PR shortly to branch v3.4.0

[sbillinge]

Ok. Sounds good. Are you able to make a PR?

[stevenhua0320]

Ok. Sounds good. Are you able to make a PR?

Have made that PR, see #190

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.20%. Comparing base (39d41f0) to head (a05255f).
⚠️ Report is 87 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   98.93%   99.20%   +0.26%     
==========================================
  Files          13       15       +2     
  Lines        1884     2507     +623     
==========================================
+ Hits         1864     2487     +623     
  Misses         20       20              

Files with missing lines	Coverage Δ
tests/test_atom.py	98.96% <100.00%> (+1.09%)	⬆️
tests/test_expansion.py	100.00% <100.00%> (ø)
tests/test_lattice.py	99.57% <100.00%> (+0.07%)	⬆️
tests/test_loadstructure.py	98.07% <100.00%> (+0.57%)	⬆️
tests/test_p_cif.py	99.70% <100.00%> (+0.10%)	⬆️
tests/test_p_discus.py	98.85% <100.00%> (ø)
tests/test_p_pdffit.py	99.41% <100.00%> (ø)
tests/test_parsers.py	99.47% <100.00%> (ø)
tests/test_spacegroups.py	98.73% <100.00%> (+0.73%)	⬆️
tests/test_structure.py	99.80% <100.00%> (+0.02%)	⬆️
... and 3 more

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.