fix:hot-fix pdfgui functionality fix after skpkg#298
Open
stevenhua0320 wants to merge 1 commit intodiffpy:mainfrom
Open
fix:hot-fix pdfgui functionality fix after skpkg#298stevenhua0320 wants to merge 1 commit intodiffpy:mainfrom
stevenhua0320 wants to merge 1 commit intodiffpy:mainfrom
Conversation
Contributor
|
Please can you check? This seems to be failing tests. Done version compatibility on problem? |
Contributor
Ah, I read the full comment above, my apologies. I will merge this. |
Contributor
|
actually, let's go a bit more slowly. Let's finalize the release of pdffit2 (please see the issue over there), push out that full release and rerun the action here so it passes, then I will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge ready to review. We have done the skpkg for this without waiting for its dependency new version release and we merged that PR. But today when I ran it using the developer version of
diffpy.pdfgui, it gives me a lot of errors other than the python version. So, I made this PR to fix all of these.__date__variable inaboutdialog.pysince it is the only place that we need the__date__. This helps us to run thepytestsucessfully.os.pathtoPath()object to comply with the group standard.pyproject.toml, this is needed because in theskpkgit changes the actual script running thepdfgui. Therefore, I changed it back to the application and in order to comply with the name of the app in the tutorial, I also changed the name of the command fromdiffpy-pdfguiback topdfgui.After finishing up these, I ran the
pytestand also running the app, it works properly now. The CI would still failing since dependecies haven't updated to3.14yet, but now local test would confirm that everything is right now.