Skip to content

npm audit fix#7

Open
edunston wants to merge 6 commits intodevelopfrom
support/npm-fix
Open

npm audit fix#7
edunston wants to merge 6 commits intodevelopfrom
support/npm-fix

Conversation

@edunston
Copy link
Copy Markdown

npm audit fix: none breaking changes only

@mrister
Copy link
Copy Markdown

mrister commented Jun 24, 2018

Based on this discussion, it seems we should not use any package-lock.json files for non apps.
sindresorhus/ama#479
@dial-once/developers please have a reed.

Copy link
Copy Markdown

@mrister mrister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove lockfile

@edunston edunston requested review from jkernech and mrister June 28, 2018 17:00
Copy link
Copy Markdown
Contributor

@jkernech jkernech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove lock file

@edunston
Copy link
Copy Markdown
Author

edunston commented Jul 2, 2018

1 low vulnerability remaining, to fix by hand. All test passed, with one warning `/Users/Eric/Documents/Dial-Once 2017/node-logtify-logentries/src/index.js
39:7 warning Unexpected console statement no-console

✖ 1 problem (0 errors, 1 warning)`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants