Fixing fetching retry , union session parameters into a single txt file and merging output urls patch#127
Open
islamisme wants to merge 2 commits intodevanshbatham:masterfrom
Open
Fixing fetching retry , union session parameters into a single txt file and merging output urls patch#127islamisme wants to merge 2 commits intodevanshbatham:masterfrom
islamisme wants to merge 2 commits intodevanshbatham:masterfrom
Conversation
|
i solved most of the issue here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were mainly 3 issue with the code
Retry mechanism logic is to stop after 3 tries , @nitish800 have changed this issue to continue to the next URL and I formatted it to be more user friendly
Any URL with slash sign " / " etc...(example.com/my) will be passed normally as an input the process of fetching will work fine until creating the txt name with that URL containing slash sign "/" , the script will raise error that
result_file = os.path.join(results_dir, f"{domain}.txt")cant create such txt file and that's normal cause @@Linux file system cant accept / as a name as it is represents directories ,I have replaced it with fraction slash character "\u2044" , this will be effective when a user inputs a redirected subdomain comes from another toolThe parameters for every domain is saved in a txt file with the name of that domain so most hunters will have to merge them by the CLI like
cat * > params.txtso I have made additional feature that saves all generated parameters in a txt file for every session aka execute of the script named by the date and time of the execution of the sctipt example (Session : 2024_06_13_20:41:27.txt)