enchant: allow toggling individual dictionaries#32
Open
WhyNotHugo wants to merge 2 commits intodesktop-app:masterfrom
Open
enchant: allow toggling individual dictionaries#32WhyNotHugo wants to merge 2 commits intodesktop-app:masterfrom
WhyNotHugo wants to merge 2 commits intodesktop-app:masterfrom
Conversation
|
|
WhyNotHugo
added a commit
to WhyNotHugo/tdesktop
that referenced
this pull request
Oct 7, 2025
Allow disabling and enabling individual dictionaries with the Enchant/Hunspell backend. This is mostly relevant in shared systems (where different users want to enable different sets of languages) or on distributions which install an exorbitant amount of dictionaries by default. Depends-On: desktop-app/lib_spellcheck#32
Contributor
Author
|
Preliminary review of the above patches:
|
Contributor
|
I believe all workarounds were made because all dictionaries are enabled by default |
WhyNotHugo
added a commit
to WhyNotHugo/lib_spellcheck
that referenced
this pull request
Oct 13, 2025
These workarounds were only necessary when choosing dictionaries was not possible. See: desktop-app#32
WhyNotHugo
force-pushed
the
enchant-toggle-dicts
branch
from
c3a5e87 to
85ac960
Compare
Author
|
Workarounds removed. Added an API to query whether toggling dictionaries is possible. |
WhyNotHugo
added a commit
to WhyNotHugo/tdesktop
that referenced
this pull request
Oct 13, 2025
Allow disabling and enabling individual dictionaries with the Enchant/Hunspell backend. This is mostly relevant in shared systems (where different users want to enable different sets of languages) or on distributions which install an exorbitant amount of dictionaries by default. Depends-On: desktop-app/lib_spellcheck#32
WhyNotHugo
added a commit
to WhyNotHugo/lib_spellcheck
that referenced
this pull request
Oct 13, 2025
These workarounds were only necessary when choosing dictionaries was not possible. See: desktop-app#32
WhyNotHugo
force-pushed
the
enchant-toggle-dicts
branch
from
85ac960 to
bc8e029
Compare
WhyNotHugo
added a commit
to WhyNotHugo/tdesktop
that referenced
this pull request
Oct 13, 2025
Allow disabling and enabling individual dictionaries with the Enchant/Hunspell backend. This is mostly relevant in shared systems (where different users want to enable different sets of languages) or on distributions which install an exorbitant amount of dictionaries by default. Depends-On: desktop-app/lib_spellcheck#32
Allow disabling and enabling individual dictionaries with the Enchant/Hunspell backend. This is mostly relevant in shared systems (where different users want to enable different sets of languages) or on distributions which install an exorbitant amount of dictionaries by default. The SupportsToggleDictionaries() method should be used to determine whether this is supported in the current environment. The macOS and Windows both currently return false, with the latter apparently being feasible but out of scope.
These workarounds were only necessary when choosing dictionaries was not possible. See: desktop-app#32
WhyNotHugo
force-pushed
the
enchant-toggle-dicts
branch
from
174337c to
f965a71
Compare
WhyNotHugo
added a commit
to WhyNotHugo/tdesktop
that referenced
this pull request
Oct 16, 2025
Allow disabling and enabling individual dictionaries with the Enchant/Hunspell backend. This is mostly relevant in shared systems (where different users want to enable different sets of languages) or on distributions which install an exorbitant amount of dictionaries by default. Depends-On: desktop-app/lib_spellcheck#32
Author
|
CI builds for telegram are now passing. This is ready for another round of review. |
23rd
reviewed
Nov 21, 2025
| not_null<QMenu*> menu, | ||
| QTextCursor cursorForPosition, | ||
| FnMut<void(int firstSuggestionIndex)> show) { | ||
| const auto customItem = !Platform::Spellchecker::IsSystemSpellchecker() |
Collaborator
There was a problem hiding this comment.
Why did you remove !Platform::Spellchecker::IsSystemSpellchecker()?
23rd
reviewed
Dec 11, 2025
Comment on lines
+279
to
+282
| std::vector<QString> WindowsSpellChecker::availableLanguages() { | ||
| // SupportsToggleDictionaries() returns false; not implemented. | ||
| return {}; | ||
| } |
Collaborator
There was a problem hiding this comment.
@WhyNotHugo I dont like these names. If it used for dictionaries, so let it be like "available languages for dictionaries".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow disabling and enabling individual dictionaries with the Enchant/Hunspell backend.
This is mostly relevant in shared systems (where different users want to enable different sets of languages) or on distributions which install an exorbitant amount of dictionaries by default.