Add Nullable version of uniqueidentifier#608
Open
jeebiq wants to merge 1 commit intodenisenkom:masterfrom
Open
Add Nullable version of uniqueidentifier#608jeebiq wants to merge 1 commit intodenisenkom:masterfrom
jeebiq wants to merge 1 commit intodenisenkom:masterfrom
Conversation
Owner
|
Why do you think this is the right way of adding new type support? |
Author
|
I didn't see anything in the readme about how you wished to have anything new added, so I added as new/dedicated files to keep it as simple as possible for me without touching the existing code. |
Owner
|
You need to add a roundtrip test with the actual SQL server. One test should set a value in the SQL and read it uniqueidentifier. Another test should verify sending uniqueidentifier value into SQL server and then read it back and compare with original. Each test should test actual value and NULL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.