passing context to the tokenprovider func#597
Open
serbrech wants to merge 4 commits intodenisenkom:masterfrom
Open
passing context to the tokenprovider func#597serbrech wants to merge 4 commits intodenisenkom:masterfrom
serbrech wants to merge 4 commits intodenisenkom:masterfrom
Conversation
serbrech
changed the title
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
=======================================
Coverage 68.72% 68.72%
=======================================
Files 23 23
Lines 5190 5190
=======================================
Hits 3567 3567
Misses 1410 1410
Partials 213 213
Continue to review full report at Codecov.
|
Author
|
Is there anyone reviewing PRs for this project? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the tokenprovider func is chanigng in this PR:
#547
Seeing as it might possibly take some time to land the PR in master, I'd like to provide a simpler update to the tokenprovider func and pass it the context.