Refactor out all mssql defined data types into a mssqltypes subpackage#518
Open
yukiwongky wants to merge 17 commits intodenisenkom:masterfrom
Open
Refactor out all mssql defined data types into a mssqltypes subpackage#518yukiwongky wants to merge 17 commits intodenisenkom:masterfrom
yukiwongky wants to merge 17 commits intodenisenkom:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
==========================================
- Coverage 68.67% 68.49% -0.18%
==========================================
Files 22 20 -2
Lines 5056 4984 -72
==========================================
- Hits 3472 3414 -58
+ Misses 1379 1367 -12
+ Partials 205 203 -2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
==========================================
- Coverage 68.86% 68.72% -0.14%
==========================================
Files 22 20 -2
Lines 5058 5004 -54
==========================================
- Hits 3483 3439 -44
+ Misses 1369 1361 -8
+ Partials 206 204 -2
Continue to review full report at Codecov.
|
denisenkom
reviewed
Sep 13, 2019
Contributor
Author
|
I've pulled Error out from this PR. @denisenkom can you check? |
Owner
|
This needs to be rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of issue #357