Add world-size getter in Engine#7479
Conversation
|
Thanks for this PR. Can you please add some UTs? |
|
@sfc-gh-truwase |
|
@WoosungMyung that works. Thanks so much! |
be8f7df to
3f5165d
Compare
Signed-off-by: WoosungMyung <dntjd517@naver.com>
3f5165d to
59eb3cb
Compare
|
@sfc-gh-truwase |
|
@WoosungMyung thanks for creating the unit tests. However, after reviewing it I realized that I gave you misleading information in terms of the location of the tests. I apologize for that. I think the tests belong in this folder with existing TP and PP tests. |
|
@WoosungMyung are you still working on this? Thanks! |
This PR adds getter methods to
DeepSpeedEngine / PipelineEngine:get_parallel_world_sizes(): returns parallelism world size as a dictionary, e.g.{"tp": 4, "dp": 8}Why
When integrating DeepSpeed with logging and experiment tracking tools such as Weights & Biases, it is often useful to record the parallelism configuration (world sizes for each Parallelism). Currently, there is no convenient getter method for each parallelism world size at once.
Benefits
Thanks for your precious time for reviewing this PR.
Thanks