Skip to content

Fix float inference to use DoubleParameter (64-bit) instead of FloatP… #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shubhambhusate wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Fix float inference to use DoubleParameter (64-bit) instead of FloatP… #742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/databricks/sql/parameters/native.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ def dbsql_parameter_from_primitive(
elif isinstance(value, str):
return StringParameter(value=value, name=name)
elif isinstance(value, float):
return FloatParameter(value=value, name=name)
return DoubleParameter(value=value, name=name)
elif isinstance(value, datetime.datetime):
return TimestampParameter(value=value, name=name)
elif isinstance(value, datetime.date):
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/test_parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ def test_tspark_param_ordinal(self):
(BigIntegerParameter, Primitive.BIGINT),
(BooleanParameter, Primitive.BOOL),
(DateParameter, Primitive.DATE),
(FloatParameter, Primitive.FLOAT),
(DoubleParameter, Primitive.FLOAT),
(VoidParameter, Primitive.NONE),
(TimestampParameter, Primitive.TIMESTAMP),
(MapParameter, Primitive.MAP),
Expand All @@ -305,7 +305,7 @@ def test_tspark_param_ordinal(self):
def test_inference(self, _type: TDbsqlParameter, prim: Primitive):
"""This method only tests inferrable types.

Not tested are TinyIntParameter, SmallIntParameter DoubleParameter and TimestampNTZParameter
Not tested are TinyIntParameter, SmallIntParameter, FloatParameter and TimestampNTZParameter
"""

inferred_type = dbsql_parameter_from_primitive(prim.value)
Expand Down