Graphql examples changes

[mickhansen]

No description provided.

[netlify]

❌ Deploy Preview for criipto-docs failed.

Name	Link
🔨 Latest commit	326513d
🔍 Latest deploy log	https://app.netlify.com/projects/criipto-docs/deploys/69986063c942f200082b7276

[netlify]

✅ Deploy Preview for criipto-docs ready!

Name	Link
🔨 Latest commit	f99285e
🔍 Latest deploy log	https://app.netlify.com/projects/criipto-docs/deploys/699d74567f913b0008435a99
😎 Deploy Preview	https://deploy-preview-295--criipto-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[sgryt]

The "Include signature information" seems to be acting up (not respecting the selected language)

[sgryt]

Dropdown with lang-select is also missing

[haysch]

Dropdown with lang-select is also missing

same goes for "Sign as a signatory"

[sgryt]

Maybe because there are no explicit examples for these (in other langs), and then the docs do not explicitly select the version chosen on one of the other examples (or as set by the Skip link) ?

[sgryt]

Maybe we should always have 2 options in the dropdown: "Raw" GQL (unauthenticated), and then "Live GQL" ?
Would always make it possible to swap between the 2, no matter how many other-lang examples we have available ?

[sgryt]

same goes for "Sign as a signatory"

This seems to be off - should the 'MUST be' have been boldface ?

[mickhansen]

Maybe we should always have 2 options in the dropdown: "Raw" GQL (unauthenticated), and then "Live GQL" ? Would always make it possible to swap between the 2, no matter how many other-lang examples we have available ?

@sgryt Good idea I think, will explore that approach.

[sgryt]

Maybe we should always have 2 options in the dropdown: "Raw" GQL (unauthenticated), and then "Live GQL" ? Would always make it possible to swap between the 2, no matter how many other-lang examples we have available ?

@sgryt Good idea I think, will explore that approach.

"Raw" GQL would also be a good fallback for all examples not matching the selected choice

[mickhansen]

@haysch @sgryt PR updated

[sgryt]

@haysch @sgryt PR updated

I had implicitly expected that if I select GraphQL and click "Skip" in one of the examples, my choice would apply to all examples, but that does not seem to be the case.
Is that intentional ?

[mickhansen]

Is that intentional ?

@sgryt Hmm, it used to, will take another look.
Ah no, never has :D But will make it so.

[mickhansen]

@sgryt Should work like that now

[haysch]

@mickhansen it does seem like the "Sign acting as" and "Include signature information" (as part of the closeSignatureOrder) does not adhere to the common definition where there is an implementation in each of the language as pointed out by @sgryt.
It does break the immersion. It does not relate directly to the change being made here, but it might be good to have it changed before/as part of, maybe? I can do that in separate PR, if you have other things to do.

[mickhansen]

@mickhansen it does seem like the "Sign acting as" and "Include signature information" (as part of the closeSignatureOrder) does not adhere to the common definition where there is an implementation in each of the language as pointed out by @sgryt. It does break the immersion. It does not relate directly to the change being made here, but it might be good to have it changed before/as part of, maybe? I can do that in separate PR, if you have other things to do.

@haysch They have never had SDK examples. SDKs do not support signActingAs atm, and "Include signature information" is a liitle nonsensical.

I think it's out of scope of this PR in any case.

[haysch]

Improvements LGTM.
The "Skip" option defaults to Raw GQL for all cases as expected, and the language selector works for all samples that have language options.
Haven't spotted other visual inconsistencies or issues.